[FE] staleTime옵션 추가 & 해더 버튼 클릭 이벤트 최적화 & 뉴스 레이아웃 #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
헤더 버튼을 클릭시 이미 해당 위치에 있어도 해당 페이지 전체가 다시 렌더링이 되는 문제 발생하여 로직 개선.
뉴스 레이아웃을 위한 초기 작업.
dongree
reviewed
Nov 25, 2024
Comment on lines
+34
to
+39
| const handleLink = (to: string) => { | ||
| if (location.pathname === to) { | ||
| return; | ||
| } | ||
| navigate(to); | ||
| }; |
There was a problem hiding this comment.
좋습니다! 페이지 이동 작업을 줄일 수 있겠네요 👍👍
Comment on lines
+2
to
+5
| const response = await fetch(`${import.meta.env.VITE_API_URL}/ranking`, { | ||
| credentials: 'include', | ||
| headers: { 'Content-Type': 'application/json' }, | ||
| }); |
There was a problem hiding this comment.
🟢 로컬에서도 잘 동작하시나요??
아마 안 되시면 이렇게 하시면 잘 동작할 겁니다 ㅎㅎ
const url = import.meta.env.PROD
? `${import.meta.env.VITE_API_URL}/ranking`
: '/api/ranking';
const response = await fetch(url, {...});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
두 가지 PR 템플릿 중 하나를 골라 작성하시면 됩니다!
✅ 주요 작업
2024-11-25.7.41.41.mov
💭 고민과 해결과정
홈화면에서 새로고침을 빠르게 했을 때 서버에서 500관련 에러가 나면서 errorBoundary에 걸리는 것을 확인했다.
따라서 해당 문제를 해결하기 위해 fetch 로직에 에러를 던지고 useQuery의 isError를 통해 확인할 수 있도록 수정했다. 이후 내부에서 isError일 경우 return을 진행하는 방식으로 수정했다.
📊 FE/BE 전체 작업 내역